Pure ASP Upload script with additional features

[Shadow Wizard]

yet another upload script, however this time it let you control
some things that most script won't handle, for example it can
check images width and height.

upload script is attached in the zip file.

sample code using this upload script:

<!-- #include file="ShadowUploader.asp" -->
<%
Dim objUpload
If Request("action")="1" Then
	Set objUpload=New ShadowUpload
	If objUpload.GetError<>"" Then
		Response.Write("sorry, could not upload: "&objUpload.GetError)
	Else  
		Response.Write("found "&objUpload.FileCount&" files...<br />")
		For x=0 To objUpload.FileCount-1
			Response.Write("file name: "&objUpload.File(x).FileName&"<br />")
			Response.Write("file type: "&objUpload.File(x).ContentType&"<br />")
			Response.Write("file size: "&objUpload.File(x).Size&"<br />")
			Response.Write("image width: "&objUpload.File(x).ImageWidth&"<br />")
			Response.Write("image height: "&objUpload.File(x).ImageHeight&"<br />")
			If (objUpload.File(x).ImageWidth>200) Or (objUpload.File(x).ImageHeight>200) Then
				Response.Write("image to big, not saving!")
			Else  
				Call objUpload.File(x).SaveToDisk(Server.MapPath("Uploads"), "")
				Response.Write("file saved successfully!")
			End If
			Response.Write("<hr />")
		Next
		Response.Write("thank you, "&objUpload("name"))
	End If
End If
%>
<form action="<%=Request.ServerVariables( "Script_Name" )%>?action=1" enctype="multipart/form-data" method="POST">
File1: <input type="file" name="file1" /><br />
File2: <input type="file" name="file2" /><br />
File3: <input type="file" name="file3" /><br />
Name: <input type="text" name="name" /><br />
<button type="submit">Upload</button>
</form>

as you can see, in the Uploader code you can control the
maximum upload size (total of all files plus form data) and
various messages.

the upload take place once you initialize the upload object.
however, the files will not be saved to disk until
SaveToDisk method is called!

you can check file type by ContentType or FileName, and you
can check if the file is valid image by checking the ImageWidth
or ImageHeight: if they're -1 it's not valid image.

revision history

1. fixed file name problem - thanks Shem for pointing on this problem.
2. fixed problem causing you could not use Response.Redirect
   after you saved the uploaded files - thanks Shemzilla!
3. changed the code so that passing new file name without
   extension will use the original extension.
4. changed the code so that it would append extension of
   original file to the given fie name, if this given file name does
   not have any extension.

Related threads:
Errors:
getting Permission Denied error
script hangs on SaveToDisk call
Bad file name or number error
getting Operation Not Allowed error
Server.CreateObject Access Error when creating Scripting.Dictionary
Invalid procedure call or argument: 'MidB' error when uploading
Browser just hangs, file is not uploaded

Additional Features:
uploading whole directory
resize the uploaded images on the fly
inserting uploaded images names to database
email the uploaded file
Get files by their corresponding form element name

General Help:
where the uploaded files will be saved?
uploading any file (not only images)
uploading large files
preventing user from uploading non image files
help implementing the code
change the name of the uploaded file change it completely
display uploaded image after uploading it
integrating the upload with existing code
using GetFileIndexByName with non IE browsers

[baseballdude_]

Wow dude! this rocks! I have an idea how, but I didn't wanna mess anything up...how do I only allow images?

Also, I found that to make the file if you're manually naming it to have the valid extension regardless, the If statement can look like this:

		If Len(strNewFileName) = 0 Then
			strPath = strPath & m_fileName
		Else  
			strPath = strPath & strNewFileName & Right(m_fileName, InStrRev(m_fileName, "."))
		End If

Seriously though dude, great work!

[Shadow Wizard]

as I said, you can check if the file is valid image by checking ImageWidth - if
it's -1 the file is not valid image, regardless of its extension. for example:

		Response.Write("found "&objUpload.FileCount&" files...<br />")
		For x=0 To objUpload.FileCount-1
			Response.Write("file name: "&objUpload.File(x).FileName&"<br />")
			Response.Write("file type: "&objUpload.File(x).ContentType&"<br />")
			Response.Write("file size: "&objUpload.File(x).Size&"<br />")
			If objUpload.File(x).ImageWidth<0 Then
				Response.Write("invalid image!")
			Else  
				Response.Write("image width: "&objUpload.File(x).ImageWidth&"<br />")
				Response.Write("image height: "&objUpload.File(x).ImageHeight&"<br />")
				If (objUpload.File(x).ImageWidth>200) Or (objUpload.File(x).ImageHeight>200) Then
					Response.Write("image to big, not saving!")
				Else  
					Call objUpload.File(x).SaveToDisk(Server.MapPath("Uploa  ds"), "")
					Response.Write("file saved successfully!")
				End If
			End If
			Response.Write("<hr />")
		Next
		Response.Write("thank you, "&objUpload("name"))

this will not save non-image files. as for extension, I fear I didn't understand what you
mean - you try to save the file with different extension??

[baseballdude_]

I'm sorry I missed the check image part shadow, i was so excited to see the code

this will not save non-image files. as for extension, I fear I didn't understand what you
mean - you try to save the file with different extension??

I was talking about if you want to save the file with a different name - the code I gave makes sure the correct extension is attached.

[Shadow Wizard]

I'm sorry I missed the check image part shadow, i was so excited to see the code

I was talking about if you want to save the file with a different name - the code I gave makes sure the correct extension is attached.

yep, that's true... this way only file name can be passed without extension. well done!

[MARKEDAGAIN]

is there any way of changing the image width ,height or quality while saving it to disk.

[Shadow Wizard]

is there any way of changing the image width ,height or quality while saving it to disk.

nope, classic ASP has its limits, that's one of them...
you'll have to install and use some 3rd party component for this, or better yet - switch
to ASP.NET where it's possible using simple code.

[Shadow Wizard]

update: fixed bug with multiply file upload which crashed.
credit for this goes to Olórin - thanks!

[Shadow Wizard]

Important update:
improved efficiency of the upload script. files up to 10 MB should be
uploaded very fast.

[Shadow Wizard]

Thanks, the script blocking did the trick. Strange, NAV is supposed to prompt for action when it blocks scripts. As well, all my other ASP code was working fine..just not the savetodisk.

Thanks!

Regards,
Jeff Wickenheiser

no problem, you're not alone in this.. it's one of the most common problems I've seen.
NAV prompts only when it find virus, Script Blocking is done silently behind the scenes.

[degsy]

Where is the best part in the script to change the filename.

e.g.
original image name = myimage.jpg

before saving to disk append the date (would require to split the filename at the period, append the date, then rejoin the parts)
myimage_01062006.jpg

or prefix the image name with objUpload("name") from the form
username_myimage.jpg

[Shadow Wizard]

the second parameter in the SaveToDisk method is the file name to use when
saving the file - if left blank, the original file name will be used.
or are you asking how to append the date to the file name?

[Shadow Wizard]

I have cleaned up this thread and Splitted each group of posts into its
own thread. the links can be found in the first post in this thread under
"Related threads".

Please start new thread, pointing on this one, if you got any specific problem
with the ShadowUploader.

For general questions or problems, post here and worst case I'll move it when
the time come.

[PaulJS]

Hey Shadow Wizard

Great looking script, having a bit of trouble using it though.

Im getting an error that says "nothing to upload" well i know the file is there, so any ideas?

Cheers

[Shadow Wizard]

hey Paul glad to see you chose my uploader.. this
error means you didn't send any files or you didn't
set multipart/form-data for the form.

post your full HTML and we'll see...