Page 2 - VBScript - Database - General - Update wont work

Couch Potato Wizard

Join Date: Jan 2005

Location: India

Posts: 12,259

Folding Points: 1480 Folding Title: Novice Folder

Time spent in forums: 5 Months 4 Days 2 m 48 sec
Reputation Power: 2179

Quote:

Originally Posted by Rictor

Try this:

Code:

cmd.Parameters.AddWithValue("ID", NgramID);
                cmd.Parameters.AddWithValue("JezikID", JezikID);
                cmd.Parameters.AddWithValue("bigram_broj", ngram.Count);
                cmd.Parameters.AddWithValue("bigram_txt", BrojZnakova);
                cmd.ExecuteNonQuery();

Rictor, you are missing @

Code:

cmd.Parameters.AddWithValue("@ID", NgramID);
cmd.Parameters.AddWithValue("@JezikID", JezikID);
cmd.Parameters.AddWithValue("@bigram_broj", ngram.Count);
cmd.Parameters.AddWithValue("@bigram_txt", BrojZnakova);
cmd.ExecuteNonQuery();

JeromeJr, "didnt help" means what?
Did you get any error?

__________________
Laziness is my religion and Sunday is my God

Get the Mantra!

#17

October 26th, 2009, 05:51 AM

Registered User

Join Date: Oct 2009

Posts: 18

Time spent in forums: 1 h 56 m
Reputation Power: 0

in debugger all values are fine after each loop
"select" query collect all id's where bigrams (characters) are saved in table, but update wont work, i try to test every field and value and here is one of tests

example:
i insert into textbox - "ja ti on"
and it saves bigrams like this in table

Quote:

ID JezikID bigram bigram_broj bigram_txt
922 5 ja 1 6
923 5 a 1 6
924 5 t 1 6
925 5 ti 1 6
926 5 i 1 6
927 5 o 1 6
928 5 on 1 6

and then after

Quote:

foreach(Ngram ngram in m_bigramCharList)
{
cmd = new OleDbCommand("select ID from BigramChar where bigram = @bigram", conn);
cmd.Parameters.Add(new OleDbParameter("@bigram", ngram.Znakovi));
object NgramID = cmd.ExecuteScalar();
cmd.Dispose();
...

if (NgramID != null)
{
int iNgramID = (int)NgramID;

cmd = new OleDbCommand("insert into tbl_ID (charID) VALUES (@ID)", conn);
cmd.Parameters.Add(new OleDbParameter("@ID", iNgramID));
...

i have

Quote:

ID charID
590 922 - ID of ja
591 923 - ID of a
592 924 - ...
593 925
594 926
595 927
596 928

but he wont update even he collects ID's of bigrams?
and thats really weird

#18

October 26th, 2009, 01:14 PM

Contributing User

Join Date: Mar 2006

Posts: 326

Time spent in forums: 1 Week 1 Day 18 h 3 m 9 sec
Reputation Power: 213

Quote:

Originally Posted by micky

Rictor, you are missing @

Code:

cmd.Parameters.AddWithValue("@ID", NgramID);
cmd.Parameters.AddWithValue("@JezikID", JezikID);
cmd.Parameters.AddWithValue("@bigram_broj", ngram.Count);
cmd.Parameters.AddWithValue("@bigram_txt", BrojZnakova);
cmd.ExecuteNonQuery();

Actually I wasn't. The @ is only to declare the name of the parameter, you don't need to use it when refering to it or assigning it a value. Promise

I always use parameters now (to protect from SQL Injection of course) and I've never once used them with the @ in the addwithvalue clause. But of course you have to when declaring the parameter in the sql statement.

Now I have no clue if it can work both ways, with the @ or without - I've never tried with the @... but I know it works without for sure

Last edited by Rictor : October 26th, 2009 at 01:18 PM.

#19

October 26th, 2009, 01:19 PM

Contributing User

Join Date: Mar 2006

Posts: 326

Time spent in forums: 1 Week 1 Day 18 h 3 m 9 sec
Reputation Power: 213

Quote:

Originally Posted by JeromeJr

didn't help

and what about using dictionary class to store ID's after "select" query and then try to update?

So what happened? Same thing as the original.... pretends to update but never changes anything in the database?

#20

October 26th, 2009, 02:09 PM

Registered User

Join Date: Oct 2009

Posts: 18

Time spent in forums: 1 h 56 m
Reputation Power: 0

after

Code:

cmd.Parameters.AddWithValue("@ID", NgramID);
cmd.Parameters.AddWithValue("@JezikID", JezikID);
cmd.Parameters.AddWithValue("@bigram_broj", ngram.Count);
cmd.Parameters.AddWithValue("@bigram_txt", BrojZnakova);
cmd.ExecuteNonQuery();

query updates in new field, so therefore, inserts. and when i try to do this

Code:

cmd = new OleDbCommand("UPDATE BigramChar SET bigram_broj = bigram_broj + 1213, bigram_txt = bigram_txt + 123123 where ID = @ID", conn);

query update successful bigram_broj and bigram_txt
so when i put numbers he updates, BUT when i try @"value" it does not want to update fields
yes on update query pretends to update but never changes anything in the database...

#21

October 26th, 2009, 04:03 PM

Contributing User

Join Date: Mar 2006

Posts: 326

Time spent in forums: 1 Week 1 Day 18 h 3 m 9 sec
Reputation Power: 213

The only thing I can think of is maybe one of the values you're passing as a parameter isn't what it needs to be.

Try doing this and see what the results are:

Code:

cmd.Parameters.AddWithValue("@ID", NgramID);
cmd.Parameters.AddWithValue("@JezikID", JezikID);
cmd.Parameters.AddWithValue("@bigram_broj", ngram.Count);
cmd.Parameters.AddWithValue("@bigram_txt", BrojZnakova);
Response.write("NgramID: " & ngramID & ", JezikID: " & JezikID & ", NgramCount: " & ngram.Count & ", bigram_txt: " & BrojZnakova)
'cmd.ExecuteNonQuery();

That way we can see what values it's actually trying to update with.

#22

October 26th, 2009, 06:22 PM

Registered User

Join Date: Oct 2009

Posts: 18

Time spent in forums: 1 h 56 m
Reputation Power: 0

response.write cannot be there. error is

and "&" cannot be between string and int

do you have any opinion?

#23

October 27th, 2009, 03:26 AM

Couch Potato Wizard

Join Date: Jan 2005

Location: India

Posts: 12,259

Time spent in forums: 5 Months 4 Days 2 m 48 sec
Reputation Power: 2179

Quote:

Originally Posted by Rictor

Actually I wasn't. The @ is only to declare the name of the parameter, you don't need to use it when refering to it or assigning it a value. Promise

I always use them so i thought there are mandatory

#24

October 27th, 2009, 03:32 AM

Couch Potato Wizard

Join Date: Jan 2005

Location: India

Posts: 12,259

Time spent in forums: 5 Months 4 Days 2 m 48 sec
Reputation Power: 2179

Quote:

Originally Posted by JeromeJr

response.write cannot be there. error is

and "&" cannot be between string and int

do you have any opinion?

cant understand whats going on, try changing : to -

Code:

Response.write("NgramID- " & ngramID & ", JezikID- " & JezikID & ", NgramCount- " & ngram.Count & ", bigram_txt- " & BrojZnakova)

#25

October 27th, 2009, 03:39 AM

Registered User

Join Date: Oct 2009

Posts: 18

Time spent in forums: 1 h 56 m
Reputation Power: 0

im at work now, but visual studio says that response.write cannot be written in that context or something like that.

ill check when i come home
but the most annoying thing is that debugger shows all values, and no null's or errors or strings when i expect int

#26

October 27th, 2009, 03:43 AM

Couch Potato Wizard

Join Date: Jan 2005

Location: India

Posts: 12,259

Time spent in forums: 5 Months 4 Days 2 m 48 sec
Reputation Power: 2179

Hmmm, then just run the page and see what response.write statement outputs.

I feel, there is something that we are missing here.

#27

October 27th, 2009, 03:47 AM

Registered User

Join Date: Oct 2009

Posts: 18

Time spent in forums: 1 h 56 m
Reputation Power: 0

i will and result will post here

#28

October 27th, 2009, 01:18 PM

Contributing User

Join Date: Mar 2006

Posts: 326

Time spent in forums: 1 Week 1 Day 18 h 3 m 9 sec
Reputation Power: 213

Quote:

Originally Posted by JeromeJr

response.write cannot be there. error is

and "&" cannot be between string and int

do you have any opinion?

Ahhh, when I wrote that I forgot you were using C# not vb.... replace the &'s with +'s and try again.

#29

October 28th, 2009, 11:33 AM

Registered User

Join Date: Oct 2009

Posts: 18

Time spent in forums: 1 h 56 m
Reputation Power: 0

here is output

Code:

System.Diagnostics.Debug.WriteLine("NgramID- " + NgramID + ", JezikID- " + JezikID + ", NgramCount- " + ngram.Count + ", bigram_txt- " + BrojZnakova);

Quote:

- this {NekaKaoLogika} NekaKaoLogika
BrojRijeci 1 int
BrojZnakova 2 int
CountBigramChar 1 int
CountBigramWord 1 int
CountTrigramChar 0 int
CountTrigramWord 1 int
- m_bigramCharList Count = 1 System.Collections.Generic.List<Ngram>
- [0] {Ngram} Ngram
Count 1 int
Znakovi "ja" string
+ Raw View
- m_bigramWordList Count = 1 System.Collections.Generic.List<Ngram>
- [0] {Ngram} Ngram
Count 1 int
Znakovi "ja" string
+ Raw View
m_Text "ja" string
+ m_trigramCharList Count = 0 System.Collections.Generic.List<Ngram>
+ m_trigramWordList Count = 1 System.Collections.Generic.List<Ngram>
victim "ja" string
+ Server {System.Web.HttpServerUtility} System.Web.HttpServerUtility
JezikID 5 int
iNgramID 1015 int
NgramID 1015 object {int}
- ngram {Ngram} Ngram
Count 1 int
Znakovi "ja" string
- conn {System.Data.OleDb.OleDbConnection} System.Data.OleDb.OleDbConnection
+ base {System.Data.OleDb.OleDbConnection} System.Data.Common.DbConnection {System.Data.OleDb.OleDbConnection}
ConnectionString "Provider=Microsoft.Jet.OLEDB.4.0;Data Source=D:\\Things\\vs2008\\WebSite1\\App_Data\\baz a.mdb;User Id=admin;" string
ConnectionTimeout 15 int
Database "" string
DataSource "D:\\Things\\vs2008\\WebSite1\\App_Data\\baza.mdb" string
Provider "Microsoft.Jet.OLEDB.4.0" string
ServerVersion "04.00.0000" string
State Open System.Data.ConnectionState
+ Static members
+ Non-Public members
- cmd {System.Data.OleDb.OleDbCommand} System.Data.OleDb.OleDbCommand
- base {System.Data.OleDb.OleDbCommand} System.Data.Common.DbCommand {System.Data.OleDb.OleDbCommand}
+ base {System.Data.OleDb.OleDbCommand} System.ComponentModel.Component {System.Data.OleDb.OleDbCommand}
CommandText "UPDATE BigramChar SET bigram_broj = bigram_broj + 12, bigram_txt = bigram_txt + 132 WHERE ID = @ID" string
CommandTimeout 30 int
CommandType Text System.Data.CommandType
+ Connection {System.Data.OleDb.OleDbConnection} System.Data.Common.DbConnection {System.Data.OleDb.OleDbConnection}
DesignTimeVisible true bool
+ Parameters {System.Data.OleDb.OleDbParameterCollection} System.Data.Common.DbParameterCollection {System.Data.OleDb.OleDbParameterCollection}
Transaction null System.Data.Common.DbTransaction
UpdatedRowSource Both System.Data.UpdateRowSource
+ Non-Public members
CommandText "UPDATE BigramChar SET bigram_broj = bigram_broj + 12, bigram_txt = bigram_txt + 132 WHERE ID = @ID" string
CommandTimeout 30 int
CommandType Text System.Data.CommandType
+ Connection {System.Data.OleDb.OleDbConnection} System.Data.OleDb.OleDbConnection
DesignTimeVisible true bool
+ Parameters {System.Data.OleDb.OleDbParameterCollection} System.Data.OleDb.OleDbParameterCollection
+ Transaction null System.Data.OleDb.OleDbTransaction
UpdatedRowSource Both System.Data.UpdateRowSource
+ Static members
+ Non-Public members

all values are fine to me! and when i insert "ja sam ja" he changes value and everything looks good!

only i changed update statement just to check how he work with @ID and it works great!

#30

October 29th, 2009, 03:18 AM