|
|||||||||
|
|||||||||
|
|||||||||
 |
|||||||||
| |
||
|
|
|
|
|||||||||
|
|||||||||
|
|||||||||
|
|||||||||
| |
||
|
|
|
| |||||||||
 |
|
|
«
Previous Thread
|
Next Thread
»
|
Thread Tools | Search this Thread | Rate Thread | Display Modes |
ASP Free Forums Sponsor:
|
|
|
|
#1
March 24th, 2006, 06:07 PM
|
|||
|
|||
|
Final year project http://www.e-learninginfo.co.uk
Hi all
For the last 6-/+ months i've been working away on my final year project for uni. www.e-learninginfo.co.uk Any comments on the site would be great. The site based around e-learning objects. where you can look through a database for learning material and build up your own course from the different objects. Database only has coulpe object in it for now. based around audio This is my second site in ASP.NET so there still most likely wil be bugs in it(hopefuly found then all). If u come across any please let me no. Thank you for taking the site to look Chris
|
|
#2
March 25th, 2006, 12:32 AM
|
||||
|
||||
|
Registration Form:
1) Why do the "Title" and "Gender" dropdown's postback the page when a selection is change? They don't change anything on the form. Set the "AutoPostBack" property to false. 2) Contact Number field. You have validation stating "Invalid number", but you don't provide a hint to the user of the format you are expecting. 3) If an input field is required you should denote it on the form. Quote:
4) Be careful of the errors you return to the client. I was able to discover you are using a SQL Server database, you are using inline SQL as opposed to using stored procedures. You have a table in your database named "people" and you aren't validating the data that you receive on the form. 5) You can't register because the registration form errors out.
|
|
#3
March 25th, 2006, 11:22 AM
|
|||
|
|||
|
Thank you for that . sorry did not notice it was bring erros. Fixed the problems. The reason has this error was i had this line of code
myDataAdapter3.SelectCommand.Parameters.Add("@Field2", levelList.SelectedItem); All fixed now . should be able to register with out any problems now 
|
|
#4
March 25th, 2006, 08:13 PM
|
||||
|
||||
|
Several pages of your site are SQL Injectible.
Ensure you are validating the data being recieved from the client either from a form, hidden field or querystring.
|
|
#6
April 1st, 2006, 04:54 PM
|
|||
|
|||
|
Unfortunately it is not fixed, I entered a dummy email and password and decided to keep my key down and entered a 100+ aplhanumeric email address and got this .net error:
Code:
Server Error in '/' Application. String or binary data would be truncated. The statement has been terminated. It may be wise to put a max length on your email and password input boxes. Just a thought. When I eneterd a normal length email and password these errors appeared at the top of the page: Code:
System.NullReferenceException: Object reference not set to an instance of an object. at UserProfile.GetUsersName() in D:\inetpub\e-learninginfo\UserProfile.cs:line 56name System.NullReferenceException: Object reference not set to an instance of an object. at UserProfile.GetUsersEmail() in D:\inetpub\e-learninginfo\UserProfile.cs:line 76email Yout Text size links do not work in Firefox Again by using the Search link after some dodgy 100+ alphanumeric string entered it crashed your db and I once again got this .net error: Code:
Server Error in '/' Application.
String or binary data would be truncated. The statement has been terminated.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.
Exception Details: System.Data.SqlClient.SqlException: String or binary data would be truncated. The statement has been terminated.
Source Error:
Line 707: upTable.Parameters.Add("@Field1", searchbox.Text);
Line 708: upTable.Parameters.Add("@Field2", userid);
Line 709: upTable.ExecuteNonQuery();
Line 710:
Line 711:
Last edited by pws1970 : April 1st, 2006 at 05:04 PM.
|
|
#8
April 2nd, 2006, 12:15 PM
|
|||
|
|||
|
Quote:
No problem Chris lets get you an A+ for your Uni Project. 
|
|
#9
April 2nd, 2006, 08:03 PM
|
||||
|
||||
|
Quote:
hehehe Added a new alternate stylesheet for usability reasons and fixed the firefox problems. for any one who having the same problem where alternate CSS stylesheet works in IE but not Firefox, check this link out i found: http://gemal.dk/blog/2004/03/08/the...rds_in_denmark/ --------------- Quote:
is due to the table column being set at max of 50 char so that's why u got the error above when you had a value 100+, So added Max lenght to all the text boxes to 50. ---------- Code:
System.NullReferenceException: Object reference not set to an instance of an object. at UserProfile.GetUsersName() in D:\inetpub\e-learninginfo\UserProfile.cs:line 56name System.NullReferenceException: Object reference not set to an instance of an object. at UserProfile.GetUsersEmail() in D:\inetpub\e-learninginfo\UserProfile.cs:line 76email Am abit lost on that one, unsure how that has happened + what to do. give me little bit more info on it please Thanks for every ones time Chris
|
|
| Viewing: ASP Free Forums > Web Design > Site Reviews > Final year project http://www.e-learninginfo.co.uk |
| Thread Tools | Search this Thread |
| Display Modes | Rate This Thread |
|
|
 |
|
|
|
|
|
Del.icio.us
Digg
Google
Spurl
Blink
Furl
Simpy
Y! MyWeb
Linear Mode
