Site Reviews
 
Forums: » Register « |  User CP |  Games |  Calendar |  Members |  FAQs |  Sitemap |  Support | 
 
 
User Name:
Password:
Remember me
Go Back   ASP Free ForumsWeb DesignSite Reviews

Reply
Add This Thread To:
  Del.icio.us   Digg   Google   Spurl   Blink   Furl   Simpy   Y! MyWeb 
Thread Tools Search this Thread Rate Thread Display Modes
 
Unread ASP Free Forums Sponsor:
  #1  
Old July 22nd, 2005, 01:04 PM
robbt robbt is offline
Registered User
ASP Free Newbie (0 - 499 posts)
 
Join Date: Apr 2005
Posts: 5 robbt User rank is Just a Lowly Private (1 - 20 Reputation Level) 
Time spent in forums: 1 h 4 m 20 sec
Reputation Power: 0
Post Review my latest project

Hi All!
Can you please review my latest asp project, Room Booking System. Room Booking System is a flexible software package for controlling classroom utilisation for schools and colleges. You can view a demo of the system at:

http://www.roombookingsystem.co.uk/website/demo.asp

Any Comments/Improvements you can think of are much appreciated!

Reply With Quote
  #2  
Old July 22nd, 2005, 01:09 PM
Memnoch's Avatar
Memnoch Memnoch is offline
Unholy Moderator
ASP Free God 14th Plane (11500 - 11999 posts)
 
Join Date: Oct 2003
Location: In hell, where did you think?
Posts: 11,760 Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level) 
Time spent in forums: 3 Weeks 5 Days 5 h 22 m 16 sec
Reputation Power: 443
-- Moved to Site Reviews forum

Reply With Quote
  #3  
Old July 22nd, 2005, 01:20 PM
Memnoch's Avatar
Memnoch Memnoch is offline
Unholy Moderator
ASP Free God 14th Plane (11500 - 11999 posts)
 
Join Date: Oct 2003
Location: In hell, where did you think?
Posts: 11,760 Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level)Memnoch User rank is Lieutenant Colonel (40000 - 50000 Reputation Level) 
Time spent in forums: 3 Weeks 5 Days 5 h 22 m 16 sec
Reputation Power: 443
Spelling Errors:

1) Organisation is spelled Organization

2) Efficicent is spelled Efficient

3) matience is spelled maintenance

Error when clicking a date in the "Quick Booking" calendar in the admin section.
Quote:
ADODB.Field error '800a0bcd'

Either BOF or EOF is True, or the current record has been deleted. Requested operation requires a current record.

/mchs/login/teacher/calendar2.asp, line 150


You aren't validating your querystring data.
I hacked changed your querystring values and received the following error.
I actually received different types of errors depending on the querystring value I changed.
Quote:
ADODB.Field error '800a0bcd'

Either BOF or EOF is True, or the current record has been deleted. Requested operation requires a current record.

/demo/login/teacher/editdetails.asp, line 449

I didn't have time to try any javascript hacking though, so you may also have issues there.

Reply With Quote
  #4  
Old July 22nd, 2005, 06:10 PM
Shadow Wizard's Avatar
Shadow Wizard Shadow Wizard is offline
Moderator From Beyond
Click here for more information.
 
Join Date: Sep 2004
Location: Israel
Posts: 26,969 Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)  Folding Points: 342040 Folding Title: Super Ultimate Folder - Level 1Folding Points: 342040 Folding Title: Super Ultimate Folder - Level 1Folding Points: 342040 Folding Title: Super Ultimate Folder - Level 1Folding Points: 342040 Folding Title: Super Ultimate Folder - Level 1Folding Points: 342040 Folding Title: Super Ultimate Folder - Level 1Folding Points: 342040 Folding Title: Super Ultimate Folder - Level 1
Time spent in forums: 3 Months 1 Week 5 Days 15 h 9 m 16 sec
Reputation Power: 1556
--comments:
1. the screen shots are too small, make them links to the full screen shots.
2. spelling errors in the main page. makes it look not professional.
3. the Copyright statement is better be written in smaller font and further down the page.
4. email in the contact page should be link.
5. as Memnoch said, clicking the dates in the calendar generates error. should not happen even in demo version - simply remove the calendar if it's not active in demo.
6. you better separate the username used to log in (e.g. "demo") from the real user name i.e. add another field to the database. this way it would feel more nice to use the system.
7. the html is not valid: in the main page you miss this:
Code:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

and in other pages you have js code appear in the beginning of the html - move the js inside the head section of the page.


anyhow the general design is nice and simple, the website works fine with Firefox.

Reply With Quote
  #5  
Old July 23rd, 2005, 10:15 AM
elijathegold's Avatar
elijathegold elijathegold is offline
Senior Fire Wizard
Click here for more information
 
Join Date: Feb 2005
Location: Ashford, Kent. England
Posts: 5,651 elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)  Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4
Time spent in forums: 2 Months 2 Weeks 2 Days 3 h 59 m 9 sec
Reputation Power: 301
Quote:
Originally Posted by Memnoch
Spelling Errors:

1) Organisation is spelled Organization



Not in the UK (we spell it correctly )

All other comments are agreed with
__________________
And he picked it all up... in his pick-up.





Friends of Shemzilla

Last edited by elijathegold : July 23rd, 2005 at 10:17 AM.

Reply With Quote
  #6  
Old July 23rd, 2005, 11:10 AM
lewy's Avatar
lewy lewy is offline
Alter Ego Wizard
ASP Free Specialist (4000 - 4499 posts)
 
Join Date: Jun 2004
Location: Edinburg Tx
Posts: 4,376 lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)lewy User rank is General 6th Grade (Above 100000 Reputation Level)  Folding Points: 1009 Folding Title: Novice Folder
Time spent in forums: 1 Month 1 Week 1 Day 21 h 21 m 31 sec
Reputation Power: 1391
I like it. It looks simple and therefore it's fine.
On your admin side, you have errors when trying to edit classes.
All this in addition to what's been said before.
__________________
................... ASCII and ye shall receive ..................
Knowledge is the only resource on earth that multiplies when shared


Support the Shemzilla Project
Powered by C#

Reply With Quote
  #7  
Old July 24th, 2005, 07:55 AM
robbt robbt is offline
Registered User
ASP Free Newbie (0 - 499 posts)
 
Join Date: Apr 2005
Posts: 5 robbt User rank is Just a Lowly Private (1 - 20 Reputation Level) 
Time spent in forums: 1 h 4 m 20 sec
Reputation Power: 0
Thanks!

Thanks For All Your Comments!

I'll get onto correcting the spelling mistakes right away.

To answer Shadow Wizard's 1th Point, I really like the idea of making the screen shots full size when you click on them, i'll include this on the website asap.

To answer Shadow Wizard's 6th Point, there is a separate field in the database which contains the users forename and surname (I think this is what you mean)

Again, to answer his 7th point, it would be a right pain to edit every page to include the validating so i'm not sure if I should do this. Does anyone know the advantages of doing this?

It is unusual that the calendar and the classes page (in admin) do not work as they seem fine in 'live' versions of the system. I'll see if copying the working files over the ones with errors works.

Thanks again for all your comments/improvements!

Reply With Quote
  #8  
Old July 24th, 2005, 08:09 AM
Shadow Wizard's Avatar
Shadow Wizard Shadow Wizard is offline
Moderator From Beyond
Click here for more information.
 
Join Date: Sep 2004
Location: Israel
Posts: 26,969 Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)Shadow Wizard User rank is General 8th Grade (Above 100000 Reputation Level)  Folding Points: 342040 Folding Title: Super Ultimate Folder - Level 1Folding Points: 342040 Folding Title: Super Ultimate Folder - Level 1Folding Points: 342040 Folding Title: Super Ultimate Folder - Level 1Folding Points: 342040 Folding Title: Super Ultimate Folder - Level 1Folding Points: 342040 Folding Title: Super Ultimate Folder - Level 1Folding Points: 342040 Folding Title: Super Ultimate Folder - Level 1
Time spent in forums: 3 Months 1 Week 5 Days 15 h 9 m 16 sec
Reputation Power: 1556
Quote:
To answer Shadow Wizard's 6th Point, there is a separate field in the database which contains the users forename and surname (I think this is what you mean)

cool, so you better use those fields in the welcome message.

Quote:
Again, to answer his 7th point, it would be a right pain to edit every page to include the validating so i'm not sure if I should do this. Does anyone know the advantages of doing this?

I don't understand - what you mean by "validating"?? I said the html is wrong.... it means it won't pass any validator, and can mess up the whole page in standard browsers. advantage of having correct html? hmm... I can see some advantages.

Reply With Quote
  #9  
Old August 9th, 2005, 11:26 AM
bslintx's Avatar
bslintx bslintx is offline
Contributing User
ASP Free Intermediate (1500 - 1999 posts)
 
Join Date: Apr 2004
Location: United States
Posts: 1,814 bslintx User rank is Corporal (100 - 500 Reputation Level)bslintx User rank is Corporal (100 - 500 Reputation Level)bslintx User rank is Corporal (100 - 500 Reputation Level)bslintx User rank is Corporal (100 - 500 Reputation Level) 
Time spent in forums: 2 Weeks 3 Days 17 h 26 m 7 sec
Reputation Power: 7
Send a message via Yahoo to bslintx
Quote:
it would be a right pain to edit every page to include the validating so i'm not sure if I should do this. Does anyone know the advantages of doing this?



yes...it's called professionalism.....and if you build it that way...they will come

in other words....you have to build a site around the users browser...w/o being html compliant...it's doomed
Comments on this post
RadioactiveFrog agrees: proxy rep from elija! Well put by the way!
__________________
Please give respect to those that helped solve an issue by clicking on the icon

Reply With Quote
  #10  
Old August 9th, 2005, 12:29 PM
elijathegold's Avatar
elijathegold elijathegold is offline
Senior Fire Wizard
Click here for more information
 
Join Date: Feb 2005
Location: Ashford, Kent. England
Posts: 5,651 elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)elijathegold User rank is Captain (20000 - 30000 Reputation Level)  Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4Folding Points: 1591513 Folding Title: Super Ultimate Folder - Level 4
Time spent in forums: 2 Months 2 Weeks 2 Days 3 h 59 m 9 sec
Reputation Power: 301
Not allowed to rep ya - but well put

Reply With Quote
  #11  
Old August 12th, 2005, 10:47 AM
RadioactiveFrog's Avatar
RadioactiveFrog RadioactiveFrog is offline
Senior Glowing Wizard
ASP Free God 7th Plane (8000 - 8499 posts)
 
Join Date: May 2005
Location: Sussex
Posts: 8,203 RadioactiveFrog User rank is Captain (20000 - 30000 Reputation Level)RadioactiveFrog User rank is Captain (20000 - 30000 Reputation Level)RadioactiveFrog User rank is Captain (20000 - 30000 Reputation Level)RadioactiveFrog User rank is Captain (20000 - 30000 Reputation Level)RadioactiveFrog User rank is Captain (20000 - 30000 Reputation Level)RadioactiveFrog User rank is Captain (20000 - 30000 Reputation Level)RadioactiveFrog User rank is Captain (20000 - 30000 Reputation Level)RadioactiveFrog User rank is Captain (20000 - 30000 Reputation Level)RadioactiveFrog User rank is Captain (20000 - 30000 Reputation Level)  Folding Points: 156607 Folding Title: Super Ultimate Folder - Level 1Folding Points: 156607 Folding Title: Super Ultimate Folder - Level 1Folding Points: 156607 Folding Title: Super Ultimate Folder - Level 1Folding Points: 156607 Folding Title: Super Ultimate Folder - Level 1Folding Points: 156607 Folding Title: Super Ultimate Folder - Level 1Folding Points: 156607 Folding Title: Super Ultimate Folder - Level 1
Time spent in forums: 3 Weeks 4 Days 39 m 12 sec
Reputation Power: 291
Send a message via MSN to RadioactiveFrog
Facebook
Quote:
Originally Posted by elijathegold
Not allowed to rep ya - but well put

proxy repped for you!
Comments on this post
elijathegold agrees: Thankyou

Reply With Quote
Reply

Viewing: ASP Free ForumsWeb DesignSite Reviews > Review my latest project


Thread Tools  Search this Thread 
Search this Thread:

Advanced Search
Display Modes  Rate This Thread 
Linear Mode Linear Mode
Hybrid Mode