Site Testing...ECommerce Shop

hey all,

I have been working on the code for a ecommerce shop, it is very basic at the moment but the idea is i implement it and keep developing it!

It is still a little way before i can release it but it is ready for testing

here is the link http://www.ukelectricalsupplies.co.uk/

Memnoch, feel free to hack away just don't do anything that will bring down the server

I know the design needs work , i am going to ask a friend if he can sort out a template for me..

any thoughts or suggestion or comments would be appreciated.

Oh, and yes i have used tables to display the product data because for me that works

Thanks,

RF

Hi there RF

just a couple of things

I cant comment on the design, because you said you are going
to get someone to do it overs, and I suck at designing NE ways

http://www.ukelectricalsupplies.co....etails.php?pi=1
the Image for this product's details goes over the basket
menu on the right of the page.

When I add a product to the basket, it stays there, maybe go
back to the list of products in that category?

I can type "a" in the qty box, it doesn't give an error but
the line price doesn't get calculated

there is no email validation when I confirm my order,
so I just typed in "asdf"

I was busy with the screen after confirm order, and I got
a session expired problem

I hope this helps a bit

How small is your screen !!!!!!! Thanks for the info tho, i willl look at that, maybe setting the z-index of the right menu would help!!

Good plan, thanks

oooops

yes, not got round to doing that yet. I will eventually but it at the moment means i don't have to enter in sensible info for testing

Can i ask what sort of session problem? was it a message i had coding in or a php/mysql error that looked horrible..

thanks for all that, it is appreciated!!

RF

hey RF,

my work pc is 17" screen running at 1024 resolution

the session expired was a nice message, like an error page

ok, thanks i will have to test it on a screen with that res so i can see for my self in the future when i change things.

The session expired thing is intended, i found on another site that there was a security issue if i got that far and did not expire the session !!

thanks,

RF

i have implemented email validation, qty validation and i have added a message to say the product has been added to the basket when adding a product from the individual display page, instead of just redirecting back to the category list. The z-index did not help the problem with the menu, just have to think something else up!

Thanks,

RF

1. It's SQL Injectible (Validate your querystring parameters).

2. Put a max length on your Quantity input fields...I was able to enter a 100 digit number. Which pretty much blew up the shopping cart upon checkout. (See the attached image)

3. I could also enter a negative number into the quantity field.

Thanks Memnoch for your time, much appreciated.

1) DOH!! -- Any guidance or more info on this?? Thanks.
2) ooops, i have put a max length on most things, forgot to put on on there....i will sort it !!
3) I will sort that too!

thank you

RF

ok, i have made the changes to solve numbers 2 & 3, could just do with some guidance on number one if you have a moment please

thanks

RF

This page

expects an integer value passed (1), but look what happens when you change the 1 to an "a".
If it expects an integer value, validate that it is in fact an integer before you go any further. Have a custom Error page to redirect to if validation fails.

If I add this

to the end of the querystring, I get this nice message.


Always validate the input you receive, whether it's from a form, the querystring or hidden fields.